[componenttest] Improve config struct checks #12590
Open
+87
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12590 +/- ##
==========================================
+ Coverage 92.18% 92.19% +0.01%
==========================================
Files 469 469
Lines 25394 25395 +1
==========================================
+ Hits 23409 23413 +4
+ Misses 1574 1572 -2
+ Partials 411 410 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
reviewed
Mar 10, 2025
Comment on lines
+107
to
+110
| case "remain": | ||
| if f.Type.Kind() != reflect.Map && f.Type.Kind() != reflect.Interface { | ||
| return fmt.Errorf(`attempt to use "remain" on non-map or interface type field %q`, f.Name) | ||
| } |
There was a problem hiding this comment.
Do we have any uses of remain currently? Should we just forbid its usage entirely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves our config struct checks by allowing for a few more cases that are possible with mapstructure.