-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[componenttest] Move CheckConfigStruct
to confmaptest
#12580
base: main
Are you sure you want to change the base?
[componenttest] Move CheckConfigStruct
to confmaptest
#12580
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (87.01%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12580 +/- ##
==========================================
- Coverage 92.18% 92.16% -0.02%
==========================================
Files 469 469
Lines 25390 25471 +81
==========================================
+ Hits 23405 23476 +71
- Misses 1574 1582 +8
- Partials 411 413 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contrib tests are broken due to the changes in mdatagen; will need a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small hiccup with this: we split all the test modules except for confmaptest, so this will be moved from a 0.x module to a 1.x module. That's okay for me but wanted to highlight it
// Deprecated: [v0.122.0] Use confmaptest.CheckConfigStruct instead. | ||
func CheckConfigStruct(config any) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Deprecated: [v0.122.0] Use confmaptest.CheckConfigStruct instead. | |
func CheckConfigStruct(config any) error { | |
// Deprecated: [v0.122.0] Use confmaptest.CheckConfigStruct instead. | |
var CheckConfigStruct = confmaptest.CheckConfigStruct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea, I'll do that.
I missed that, thanks for pointing it out. I know I want to make at least one change to this function, I'm going to make this a bit more airtight before I move it. |
@mx-psi @bogdandrutu Please see #12590. From what I can tell, we can get away without any breaking changes, but I want to confirm we're okay with how that works before we move forward. |
Description
This function is mostly concerned with config unmarshaling, so it relates much more to
confmap
than it does tocomponent
.