Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct logrus import path #8611

Closed
wants to merge 3 commits into from
Closed

Conversation

LorbusChris
Copy link

The sirupsen namespace has to be lowercase to avoid problems with
newer versions of Golang and Go Modules.

Signed-off-by: Christian Glombek [email protected]

Fixes #8263

The sirupsen namespace has to be lowercase to avoid problems with
newer versions of Golang and Go Modules.

Signed-off-by: Christian Glombek <[email protected]>
@LorbusChris LorbusChris requested a review from a team as a code owner January 19, 2020 21:15
@vmwclabot
Copy link
Member

@LorbusChris, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@LorbusChris LorbusChris changed the title Correct logrus import path [full ci] Correct logrus import path Jan 20, 2020
@LorbusChris
Copy link
Author

LorbusChris commented Jan 20, 2020

Unfortunately make test does not run locally (not on master, and not on this branch) as some of the referenced files don't exist anymore, e.g. lib/apiservers/portlayer/client/port_layer_client.go

All dependencies have already updated their imports to the lower-case variant in current versions - after all the issue is more than 2.5 years old: sirupsen/logrus#543

It is also unclear to me how the vendored deps should be updated, renaming the import in vendored files as is I did here is certainly not the right approach.

Please fix this asap.

@vmwclabot
Copy link
Member

@LorbusChris, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logrus import should be lowercase
2 participants