fix!: port forwarding clean up and make private #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
force-pushed
the
fix/port-forwarding-clean-up
branch
from
99df594 to
ee68d00
Compare
Ensure that when the port forward container is shutdown all forwarding is also stopped by switching to a context to handle cancellation correctly. Ensure that port forwarding connection attempts are cancelled correctly when the container context is cancelled, previously these could wait for a longer timeout. Don't cancel port forwarding when the context used to start a container is cancelled as this is unexpected behaviour as its a non-explicit use of the context after the function has returned. Ensure forwarding clean up errors are reported on container stop and termination. Ensure port forwarding connections are cleaned up if one of the requested ports reports an error on setup. Port forwarding test style clean up. Update sshd module to the latest version. BREAKING_CHANGE: make port forwarding type and constructor private.
stevenh
force-pushed
the
fix/port-forwarding-clean-up
branch
from
ee68d00 to
8516ea5
Compare
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Nov 19, 2024
* main: (34 commits) fix: only upload to sonar on ubuntu-latest (testcontainers#2891) fix: build artifact name properly (testcontainers#2890) fix: do not run sonar upload when ryuk is disabled (testcontainers#2889) fix: update GH actions for uploading/downloading artifacts (testcontainers#2888) feat(ci): Enable master moby with rootless (testcontainers#2880) fix(redpanda): temporary file use chore(deps): bump actions/download-artifact from 3.0.2 to 4.1.8 (testcontainers#2676) chore(deps): bump actions/upload-artifact from 3.1.3 to 4.4.3 (testcontainers#2885) fix!: port forwarding clean up and make private (testcontainers#2881) chore: resolve AWS deprecations for localstack (testcontainers#2879) docs: fix new lifecycle hooks section (testcontainers#2875) fix: host access port instability (testcontainers#2867) feat: add build to life cycle hooks (testcontainers#2653) fix: typo in containerd integration (testcontainers#2873) chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.2 (testcontainers#2806) chore: use testify instead of t.Error (testcontainers#2871) ci: enable perfsprint linter (testcontainers#2872) chore(deps): bump mkdocs-markdownextradata-plugin from 0.2.5 to 0.2.6 (testcontainers#2807) chore: use testcontainers.RequireContainerExec (testcontainers#2870) chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (testcontainers#2868) ...
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Nov 21, 2024
* main: (76 commits) fix(influxdb): Respect custom waitStrategy (testcontainers#2845) fix: only upload to sonar on ubuntu-latest (testcontainers#2891) fix: build artifact name properly (testcontainers#2890) fix: do not run sonar upload when ryuk is disabled (testcontainers#2889) fix: update GH actions for uploading/downloading artifacts (testcontainers#2888) feat(ci): Enable master moby with rootless (testcontainers#2880) fix(redpanda): temporary file use chore(deps): bump actions/download-artifact from 3.0.2 to 4.1.8 (testcontainers#2676) chore(deps): bump actions/upload-artifact from 3.1.3 to 4.4.3 (testcontainers#2885) fix!: port forwarding clean up and make private (testcontainers#2881) chore: resolve AWS deprecations for localstack (testcontainers#2879) docs: fix new lifecycle hooks section (testcontainers#2875) fix: host access port instability (testcontainers#2867) feat: add build to life cycle hooks (testcontainers#2653) fix: typo in containerd integration (testcontainers#2873) chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.2 (testcontainers#2806) chore: use testify instead of t.Error (testcontainers#2871) ci: enable perfsprint linter (testcontainers#2872) chore(deps): bump mkdocs-markdownextradata-plugin from 0.2.5 to 0.2.6 (testcontainers#2807) chore: use testcontainers.RequireContainerExec (testcontainers#2870) ...
ttruongatl
pushed a commit
to ttruongatl/testcontainers-go
that referenced
this pull request
Feb 15, 2025
Ensure that when the port forward container is shutdown all forwarding is also stopped by switching to a context to handle cancellation correctly. Ensure that port forwarding connection attempts are cancelled correctly when the container context is cancelled, previously these could wait for a longer timeout. Don't cancel port forwarding when the context used to start a container is cancelled as this is unexpected behaviour as its a non-explicit use of the context after the function has returned. Ensure forwarding clean up errors are reported on container stop and termination. Ensure port forwarding connections are cleaned up if one of the requested ports reports an error on setup. Port forwarding test style clean up. Update sshd module to the latest version. BREAKING_CHANGE: make port forwarding type and constructor private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when the port forward container is shutdown all forwarding is also stopped by switching to a context to handle cancellation correctly.
Ensure that port forwarding connection attempts are cancelled correctly when the container context is cancelled, previously these could wait for a longer timeout.
Don't cancel port forwarding when the context used to start a container is cancelled as this is unexpected behaviour as its a non-explicit use of the context after the function has returned.
Ensure forwarding clean up errors are reported on container stop and termination.
Ensure port forwarding connections are cleaned up if one of the requested ports reports an error on setup.
Port forwarding test style clean up.
Update sshd module to the latest version.
BREAKING_CHANGE: make port forwarding type and constructor private.