decode URL values

[matryer]

?something=one+two+three

Arg("something") should yield `one two three` and not `one+two+three`

[alexanderdickson]

Does this decodeURIComponent() and then apply the replacement? That seems wrong.

Example

?param=some%2bvalue

This decodes to:

some value

I'd argue that's wrong. It should be some+value still.

[wwalser]

Alex is right, any encoded url containing a + symbol now gets turned into a space instead of being a plus.

"?username=wes%2b%2b" username is "wes++" not "wes ".
"?username=wes+mcduck" on the other hand is "wes mcduck".

In the code path, you've already decodedURIComponents once when you call __decode.

[alexanderdickson]

Glad it's not just me :)

[matryer]

Anyone want to suggest a fix?

On May 2, 2014, at 12:26 AM, Alexander Dickson [email protected] wrote:

Glad it's not just me :)

—
Reply to this email directly or view it on GitHub.

[wwalser]

I'll have a shot at a PR over the weekend.