Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1948906 Add logs to chain verification #1315

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Feb 25, 2025

Description

SNOW-1948906 Added more logs describing what certs are being verified.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (f5582f4) to head (7d9c881).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   82.07%   82.08%           
=======================================
  Files          55       55           
  Lines       13722    13724    +2     
=======================================
+ Hits        11263    11265    +2     
  Misses       2459     2459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1948906-chain-verification-logs branch from 90abf0e to f11cbd5 Compare February 28, 2025 08:57
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1948906-chain-verification-logs branch from f11cbd5 to c8e3cdd Compare February 28, 2025 08:58
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review February 28, 2025 08:58
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner February 28, 2025 08:58
Copy link

gitguardian bot commented Mar 7, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) March 7, 2025 13:27
@sfc-gh-pfus sfc-gh-pfus merged commit 8ed4c75 into master Mar 7, 2025
36 of 38 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1948906-chain-verification-logs branch March 7, 2025 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants