Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1825790: Secure OAuth token cache on linux #1301

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

SNOW-1825790: Secure OAuth token cache on linux #1301

wants to merge 7 commits into from
+545 −132

Conversation

sfc-gh-jszczerbinski
Copy link

Description

SNOW-XXX Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title Update cache dir lookup SNOW-1825790: Secure OAuth token cache on linux Feb 7, 2025
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the SNOW-1825790-go-secure-o-auth-token-cache-on-linux branch from 3bd31c0 to f4b2aa8 Compare February 7, 2025 13:00
sfc-gh-pfus
sfc-gh-pfus reviewed Feb 26, 2025
View reviewed changes
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-go-secure-o-auth-token-cache-on-linux branch 2 times, most recently from 9a64875 to 6c692d5 Compare February 27, 2025 11:49
sfc-gh-pfus
sfc-gh-pfus approved these changes Feb 27, 2025
View reviewed changes
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-go-secure-o-auth-token-cache-on-linux branch 2 times, most recently from 228b00b to d95ebe7 Compare February 27, 2025 12:54
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review February 27, 2025 13:07
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner February 27, 2025 13:07
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.56318% with 76 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (b9ab4b3) to head (89b8b07).

Files with missing lines Patch % Lines
secure_storage_manager.go 72.83% 72 Missing ⚠️
os_specific_posix.go 80.00% 2 Missing ⚠️
os_specific_windows.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   82.09%   81.90%   -0.19%     
==========================================
  Files          55       57       +2     
  Lines       13722    13872     +150     
==========================================
+ Hits        11265    11362      +97     
- Misses       2457     2510      +53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-go-secure-o-auth-token-cache-on-linux branch from d95ebe7 to f3db99a Compare February 28, 2025 08:41
@sfc-gh-pfus sfc-gh-pfus self-requested a review February 28, 2025 09:03
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski commented Feb 28, 2025
View reviewed changes
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-go-secure-o-auth-token-cache-on-linux branch from 05f94a3 to 32ec3b3 Compare March 3, 2025 11:24
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-go-secure-o-auth-token-cache-on-linux branch from 32ec3b3 to 89b8b07 Compare March 3, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jszczerbinski @sfc-gh-pmotacki @sfc-gh-pfus