Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1029646: Add WithFileGetStream that supports downloading a file into stream #1192

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Aug 1, 2024

Description

SNOW-1029646: [gosnowflake][GH#654] WithFileStream support for GET queries
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/855

Added the context WithFileGetStream to support downloading a file into in-memory stream.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 70.45455% with 39 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (0e1648e) to head (e105367).
Report is 1 commits behind head on master.

Files Patch % Lines
encrypt_util.go 60.60% 13 Missing ⚠️
gcs_storage_client.go 55.55% 8 Missing ⚠️
azure_storage_client.go 73.91% 6 Missing ⚠️
connection_util.go 70.00% 6 Missing ⚠️
storage_client.go 71.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   82.48%   82.45%   -0.04%     
==========================================
  Files          54       54              
  Lines       12832    12906      +74     
==========================================
+ Hits        10585    10641      +56     
- Misses       2247     2265      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review August 8, 2024 07:00
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner August 8, 2024 07:00
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit f434413 into master Aug 27, 2024
35 of 37 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the 855-WithFileGetStream branch August 27, 2024 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants