move chunk out of loop

snowflakedb · Feb 9, 2022 · a106068 · a106068
1 parent 47a5940
commit a106068
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/encrypt_util.go b/encrypt_util.go
@@ -71,18 +71,18 @@ func encryptStream(
 
 	mode := cipher.NewCBCEncrypter(block, ivData)
 	cipherText := make([]byte, chunkSize)
+	chunk := make([]byte, chunkSize)
 
 	// encrypt file with CBC
 	for {
-		chunk := make([]byte, chunkSize)
 		n, err := src.Read(chunk)
 		if n == 0 || err != nil {
 			break
 		} else if n%aes.BlockSize != 0 || n != chunkSize {
 			chunk = padBytesLength(chunk[:n], aes.BlockSize)
 		}
 		mode.CryptBlocks(cipherText, chunk)
-		out.Write(cipherText[:len(chunk)])
+		out.Write(cipherText[:n])
 
 	}
 	if err != nil {

diff --git a/file_util.go b/file_util.go
@@ -63,9 +63,9 @@ func (util *snowflakeFileUtil) compressFileWithGzip(fileName string, tmpDir stri
 func (util *snowflakeFileUtil) getDigestAndSizeForStream(stream **bytes.Buffer) (string, int64, error) {
 	m := sha256.New()
 	r := getReaderFromBuffer(stream)
+	chunk := make([]byte, fileChunkSize)
 
 	for {
-		chunk := make([]byte, fileChunkSize)
 		n, err := r.Read(chunk)
 		if err == io.EOF {
 			break

diff --git a/telemetry.go b/telemetry.go
@@ -27,7 +27,6 @@ const (
 	reasonKey        = "reason"
 	errorNumberKey   = "ErrorNumber"
 	stacktraceKey    = "Stacktrace"
-	exceptionKey     = "Exception"
 )
 
 const (