-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce the new fully-lowercase import path with Go 1.4 mecanism #859
Conversation
The original import path of was github.com/Sirupsen/logrus but it has changed to a fully lowercase path in July 2017. References: - https://github.com/sirupsen/logrus/blob/7eeb7b7cbdeb0a582a5b7a1512d91f956f1674aa/README.md#case-sensitivity - sirupsen#570 (comment) To help dependent project to detect the issue with mixing old and new import path, let's use the Go 1.4 mecanism that enforces the import path: https://golang.org/doc/go1.4#canonicalimports This is a complement to go.mod for pre-Go-modules Go versions.
We can not merge that in v1 branch, it may break some build here and there. |
The universe that depends on logrus is already broken because of the case change. |
We did not receive any issue about the case change lastly, so I don't think there are so many broken build out there because of that. |
The situation is so broken that in fact in my company we lived for a long time without noticing the case change. We have been bitten by the issue more than one year after the case change. This patch enforces that everyone that upgrades will come in the new post-case-change world instead of staying in the ignorance. And it gives the information to the go tooling to help the user to fix the issue. |
the use of go.mod is the new standard for package management in go build. In this context the fix is not useful anymore, but it may harm users just building whatever packages are currently in the gopath. |
|
The original import path of was github.com/Sirupsen/logrus but it has
changed to a fully lowercase path in July 2017.
References:
To help dependent project to detect the issue with mixing old and new
import path, let's use the Go 1.4 mecanism that enforces the import
path: https://golang.org/doc/go1.4#canonicalimports
This is a complement to go.mod for pre-Go-modules Go versions.