MokManager: remove redundant logical constraints

[xypron]

CertList->SignatureSize is of type UINT32 which is always positive.

If CertList->SignatureListSize == 0, then
CertList->SignatureListSize <= CertList->SignatureSize
is also true.

Remove the redundant CertList->SignatureListSize == 0 checks.

A message "Corrupted signature list" is better suited then
"Invalid MOK detected! Ignoring MOK List." in this case.

Signed-off-by: Heinrich Schuchardt [email protected]

[julian-klode]

While we're at it, (void *)(CertList + 1) > end seems to be undefined behavior if it is true (CertList + 1 being out of bounds), it should be end - (void*)CertList < 1. Ah but well, types and sizes, < sizeof(*CertList).

[xypron]

@julian-klode:

(void *)(CertList + 1) > end checks that a complete entry with the same type as CertList is inside the memory area ending at pointer end and can be safely processed. The check that you propose would only require a single first byte to be available.

If you don't see anything wrong with the current patch, please, add your approval.