Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templateize the request http package #6709

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Feb 3, 2025

This package is used by both otelhttp and otelmux, and should be used by all packages using the semconv HTTP package.
So this templateizes is to make its reuse easier.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Feb 3, 2025
@github-actions github-actions bot requested a review from akats7 February 3, 2025 08:33
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8%. Comparing base (30c5607) to head (c8f6ccd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6709     +/-   ##
=======================================
- Coverage   73.9%   73.8%   -0.1%     
=======================================
  Files        195     195             
  Lines      16627   16627             
=======================================
- Hits       12291   12282      -9     
- Misses      3978    3984      +6     
- Partials     358     361      +3     
Files with missing lines Coverage Δ
...rilla/mux/otelmux/internal/request/body_wrapper.go 93.7% <ø> (ø)
...ux/otelmux/internal/request/resp_writer_wrapper.go 94.5% <ø> (-5.5%) ⬇️
...net/http/otelhttp/internal/request/body_wrapper.go 100.0% <ø> (ø)
...p/otelhttp/internal/request/resp_writer_wrapper.go 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu marked this pull request as ready for review February 3, 2025 08:40
@dmathieu dmathieu requested a review from a team as a code owner February 3, 2025 08:40
@dmathieu dmathieu merged commit aa9eaeb into open-telemetry:main Feb 4, 2025
28 checks passed
@dmathieu dmathieu deleted the templateize-request branch February 4, 2025 08:47
@MrAlias MrAlias added this to the v1.35.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants