-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bytes based batching for traces #12519
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My biggest concern about this is the required changes to pdata. I am trying to see if there is any other way to avoid that.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12519 +/- ##
==========================================
+ Coverage 92.18% 92.19% +0.01%
==========================================
Files 469 470 +1
Lines 25390 25466 +76
==========================================
+ Hits 23405 23478 +73
- Misses 1574 1578 +4
+ Partials 411 410 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ok. Please let me know if I can help with this somehow. I will very likely start working on the PRs for the other signals as well and adapt whatever is needed if there is a change. |
Signed-off-by: Israel Blancas <[email protected]>
Description
This PR implements serialized bytes based batching for traces.
Link to tracking issue
#3262
Continuation of #12299 made by @sfc-gh-sili.