Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useBearer): expose the config for static targets #327

Merged
merged 5 commits into from
Jul 25, 2022

Conversation

paologallinaharbur
Copy link
Member

Attaching the token to all request would be a security issue.

Therefore the decision was taken to attach it merely for static targets whenever the user was explicitly asking for it.

@paologallinaharbur paologallinaharbur requested a review from a team July 25, 2022 10:41
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , would make sense to add some test?

@paologallinaharbur
Copy link
Member Author

Sure, I added them!

Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double approved now 😄

@paologallinaharbur paologallinaharbur merged commit da8c0a3 into main Jul 25, 2022
@paologallinaharbur paologallinaharbur deleted the feat/exposeUSeBearer branch July 25, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants