Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating Trace.id Conditions #260

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

aavinash-nr
Copy link
Contributor

@aavinash-nr aavinash-nr commented Feb 18, 2025

Description

  • This helps to avoid calling the ExtractTraceID function if telemetry bytes is not present.

Issues

#182

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (77f01ff) to head (9b2f353).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
main.go 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   80.04%   79.63%   -0.42%     
==========================================
  Files          24       24              
  Lines        1699     1694       -5     
==========================================
- Hits         1360     1349      -11     
- Misses        271      278       +7     
+ Partials       68       67       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aavinash-nr aavinash-nr force-pushed the NR-366320-traceid branch 4 times, most recently from 9888ce0 to d5fd69c Compare February 18, 2025 13:35
@chaudharysaket chaudharysaket merged commit 270f7c5 into newrelic:main Feb 19, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants