Added integration for ms sql server with newrelic

[ishahid91]

Added intergation for ms sql server

Links

Details

Added integration for ms sql server to show database transactions on new relic. I have used the similar approach which is used in other integrations. I have added the relevant unit test and example as well which I tested on my local with sql server.

[CLAassistant]

All committers have signed the CLA.

[disiqueira-talabat]

LGFM 👍

[RichVanderwal]

Thanks, @ishahid91 , for this PR! We'll be looking at it and considering it for inclusion in the Go Agent. It looks quite straightforward, and we're hoping to test it against a real MS SQL server soon!

Note that development generally slows down at the end of the calendar year, so our team most likely won't be looking closely at it until a few weeks have passed.

[ishahid91]

Thanks @RichVanderwal for looking at the PR and considering it to include in Go Agent. I am looking forward to get it included in Go Agent ASAP as this will help us and many other teams to monitor MS SQL Server for many critical Go services.

[ishahid91]

Hi @RichVanderwal, Any update on the review ? Looking forward to get it merged so that we can integrate it into our production services.

[ishahid91]

@RichVanderwal gentle reminder.

[iamemilio]

@ishahid91 Hi, are you still interested in merging this? We will help you :)

[ishahid91]

Yes @iamemilio Can you please help merge this PR.

[iamemilio]

Overall, it looks good. Could you remove the dependency on ms-sql in the v3/go.mod file and verify that the changes still work?

[ishahid91]

Hi @iamemilio I have made the requested changes

[iamemilio]

Looks good. I will try to run this just to make sure everything checks out. Once the test is happy, and I run it, I think this will be good to go

[iamemilio]

@ishahid91 I was able to run this. Once you clean up the go lint errors, this is ready to merge: https://github.com/newrelic/go-agent/runs/6757623643?check_suite_focus=true

Thanks for submitting this, and thank you for being patient with us while we continue to grow our team!

[ishahid91]

@iamemilio fixed the linting issue, can you please run once again to verify. Thank you for your time and making it ready to merge :)

[iamemilio]

Looks good, thanks!

[ishahid91]

@iamemilio Thanks for approving the PR. When I can expect this PR to be merged ?

[iamemilio]

It will very likely be merged in time for the next release!