Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add Open Source Policy Workflow #224

Closed
wants to merge 18 commits into from
Closed

ci: Add Open Source Policy Workflow #224

wants to merge 18 commits into from

Conversation

tangollama
Copy link

Hello from the Open Source and Developer Advocacy team at New Relic.

This PR contains a GitHub actions workflow which runs repolinter, an automated tool to help us find and fix inconsistencies in our community files and public repositories. This PR registers a GitHub Actions workflow (repolinter.yml) running repolinter-action. The goal of this workflow is to make our Open Source Policy enforcement more consistent and transparent for everyone.

Repolinter Action does:

  • Scans the repository for Open Source policy issues using Repolinter.
    • The issues this workflow scans for are determined by the ruleset specified by with.config-url: this ruleset will be maintained by the Open Source and Developer Advocacy team and will not change frequently.
  • Runs only on push to the default branch, ignoring PRs and other events.
  • If any policy issues are found, this workflow will open a GitHub issue titled "Open Source Policy Issues" and with the repolinter label. This issue will contain detailed information on which policies generated errors and what changes are suggested. An example issue is here.
  • As policy issues are resolved, this workflow will update the open issue to reflect the changes. If all policy issues are resolved, the issue will automatically be closed.

This workflow is designed to cause the least amount of friction as possible:

  • This means workflow will only run on push, and as a result will not participate in status checks for PRs. Furthermore, this workflow will always exit with a passing status unless a fatal internal error occurs.
  • The goal of this workflow was not to prevent work: this means that it is up to your team to backlog the items found by this tool appropriately.
  • This workflow will only notify you when an issue is created. In other words, you will only be notified when new problems occur, but not when existing problems change.

What you should do:

  • Review this PR and workflow: make sure that the correct base branch is selected.
  • If it looks good, merge the PR and check to see if the repolinter-action runs successfully in the actions console. You can remove the branch created by this PR as it is no longer needed.
  • If you have concerns, please address them in the #help-opensource channel in Slack.
  • If there's a blocked with the CLA Assistant check of my handle (tangollama), please ignore it. I (Joel) have indeed signed our CLA... several times. The fact that the tool may not acknowledge that is deficiency in our tooling that we will address in due time.
  • The action may open a GitHub issue on this repository (it will have the repolinter label). If an issue is opened, look it over and make sure all the problems seem correct. Shoot us a ping in #help-opensource if anything looks suspicious.
  • In the future, this workflow may open issues as our open source policies are updated. Keep an eye on the GitHub issues for these updates (it may help to watch the repository).

This workflow is still in beta! If you have feedback, please let us know in #help-opensource.

Thank you for your cooperation with this policy.

purple4reina and others added 18 commits June 24, 2020 09:55
@purple4reina @newrelic-eheinlein
Update protobuf file to latest.
518fa5e 
f13a86b4b013d2ae07e78c7c27359d0a158be118
@purple4reina @newrelic-eheinlein
Log gRPC version used.
2dd077d
@purple4reina @newrelic-eheinlein
Replace usage of deprecated grpc.WithDialer. (#942)
3d1d1f0
@purple4reina @newrelic-eheinlein
Prevent debug messages unless debug level set. (#943)
be90d7b
@purple4reina @newrelic-eheinlein
Include request_headers_map from connect reply in RecordSpan metadata. (
392667a 
#940)
@purple4reina @newrelic-eheinlein
Fix code strings to match spec. (#945)
d22a643
@purple4reina @newrelic-eheinlein
Add parent.* intrinsics from transaction to root span. (#946)
a7b9d16
@newrelic-eheinlein
Update span GUID propagation (#944)
c1a8030 
* Pull in new cross agent tests (not yet passing)

* Code changes for span GUID creation

* Get tests passing

* t.Helper() was added in Go 1.9, so it can't be used here. :(

* PR feedback

* Update commit of cross-agent tests now that PR is merged
@purple4reina @newrelic-eheinlein
Never use the default transport.
722e8ab
@purple4reina @newrelic-eheinlein
When a timeout error occurs save instead of drop data.
1cd907e
@newrelic-eheinlein
Refactor trace_observer.go
cc67c36
@newrelic-eheinlein
Move defer statement to follow conventions
5c873ec
@purple4reina @newrelic-eheinlein
Refactor grpc.Dial logic. (#949)
a25652c
@purple4reina @newrelic-eheinlein
Enable GitHub Actions for CI testing.
c1a24e4
@purple4reina @newrelic-eheinlein
Add changelog entry.
d498ac2
@newrelic-eheinlein
Update version for v3.7.0 (#956)
dfd0d8b 
* Update version for v3.7.0

* Fix headings
@newrelic-eheinlein
Merge branch 'master' into master
7b8be5e
@tangollama
ci: Add Open Source Policy Workflow
4430970
@newrelic-eheinlein newrelic-eheinlein changed the base branch from master to develop September 3, 2020 18:47
@Miriam-R Miriam-R added good first issue p3 Priority 3 work items labels Nov 6, 2020
@RichVanderwal
Copy link
Contributor

The git history had gotten messy on this PR, so I made a fresh one and merged it.
#262

@RichVanderwal RichVanderwal self-assigned this Jan 7, 2021
@iamemilio iamemilio deleted the feature/repolinter-action branch August 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RichVanderwal RichVanderwal

Labels
p3 Priority 3 work items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tangollama @RichVanderwal @kneitinger @Miriam-R @purple4reina @newrelic-eheinlein