Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in v3.4.0 for nrlambda v1.0.0 #140

Closed
rittneje opened this issue Mar 31, 2020 · 2 comments
Closed

Breaking change in v3.4.0 for nrlambda v1.0.0 #140

rittneje opened this issue Mar 31, 2020 · 2 comments

Comments

@rittneje
Copy link
Contributor

When upgrading github.com/newrelic/go-agent/v3 from v3.3.0 to v3.4.0, we encountered a build failure:

github.com/newrelic/go-agent/v3/integrations/nrlambda/handler.go:48:45: undefined: internal.AttributeAWSLambdaEventSourceARN

This issue is fixed by also upgrading github.com/newrelic/go-agent/v3/integrations/nrlambda from v1.0.0 to v1.1.0. However, this was not mentioned in the release notes.
https://github.com/newrelic/go-agent/releases/tag/v3.4.0
https://docs.newrelic.com/docs/release-notes/agent-release-notes/go-release-notes/go-agent-340

@newrelic-eheinlein
Copy link
Contributor

@rittneje Thank you for letting us know about this! We apologize for missing this in our release notes. We’ve added a step to our release process to make sure that we don’t miss this again, and we will be updating the release notes and documents for the 3.4.0 release to make this clear.

Again, thank you for bringing this to our attention and apologies for the inconvenience.

@newrelic-eheinlein
Copy link
Contributor

We have updated the Changelog to note this detail. Thank you again for catching this and reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants