Merge pull request #276 from nr-swilloughby/test_8t_no_error

Change logging level for 8T rebalancing messages

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Changes
+* Changed logging level for messages resulting from Infinite Tracing load balancing operations which were previously logged as errors; now they are debugging messages. [#213](https://github.com/newrelic/go-agent/issues/213)
+
 ## 3.10.0
 
 ### New Features

ROADMAP.md

@@ -7,7 +7,7 @@ New Relic is moving toward OpenTelemetry. OpenTelemetry is a unified standard fo
 
 
 ## Roadmap
-**The roadmap project is found [here](https://github.com/newrelic/go-agent/projects/1)**.  
+**The Go instrumentation roadmap project is found [here](https://github.com/orgs/newrelic/projects/24)**.  
 
 This roadmap project is broken down into the following sections:
 

v3/newrelic/trace_observer.go

@@ -272,9 +272,22 @@ func (to *gRPCtraceObserver) rcvResponses(spanClient v1.IngestService_RecordSpan
 	for {
 		s, err := spanClient.Recv()
 		if nil != err {
-			to.log.Error("trace observer response error", map[string]interface{}{
-				"err": err.Error(),
-			})
+			// (issue 213) These two specific errors were reported as nuisance
+			// but are really harmless so we'll report them as DEBUG level events
+			// instead of ERROR.
+			// This error comes from our Infinite Tracing load balancers.
+			// We believe the EOF error comes from the gRPC getting reset every 30 seconds
+			// from the same cause (rebalancing 8T)
+			if err.Error() == "rpc error: code = Internal desc = stream terminated by RST_STREAM with error code: NO_ERROR" || err.Error() == "EOF" {
+				to.log.Debug("trace observer response error", map[string]interface{}{
+					"err": err.Error(),
+				})
+			} else {
+				to.log.Error("trace observer response error", map[string]interface{}{
+					"err": err.Error(),
+				})
+			}
+
 			// NOTE: even when the trace observer is shutting down
 			// properly, an EOF error will be received here and a
 			// supportability metric created.