Fix double single quotes in metaDescription and wrap everything in double quotes #2261
Conversation
bradleycamacho
added
content
|
Original commit did not exclude Japanese docs. Reverted that commit and pushed two separate commits which exclude Japanese docs. |
|
Building this locally now |
|
Looks like there are still 13 files with double quotes in metaDescription:
|
There was a problem hiding this comment.
Hi @bradleycamacho , looks good but noticed a few docs where there are still some double-single-quotes in the metadescription. See screenshot. Thanks for doing this cleanup!
| @@ -4,7 +4,7 @@ tags: | |||
| - Agents | |||
| - Nodejs agent | |||
| - Troubleshooting | |||
| metaDescription: 'To reduce disk space consumption, be sure to lower the ''trace'' log level after generating a troubleshooting log for your New Relic Node.js agent.' | |||
There was a problem hiding this comment.
Looks like this case with doubled up double single quotes (if that makes any sense) wasn't handled quite right. Not sure how common this is but probably worth re-searching for.
|
No longer seems worth the effort. If anyone ever reopens in the future, be sure to implement the fixes mentioned above and ensure merge conflicts are fixed. |
bradleycamacho
added
from_tw
This PR removes all double single quotes in
metaDescriptions, and wraps allmetaDescriptionsin double quotes instead.This built correctly, and I scanned a few dozen individual docs to ensure everything got replaced correctly. Please double check for me if you review this :)
Attaching the regEx I used as screenshots:
