fix(logs): (NR-371436) Clarify array support for logs #20149
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @luckslovez 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jdearana-nr
reviewed
Mar 6, 2025
| @@ -461,7 +461,8 @@ Attributes may be of any of the following types: | |||
| </td> | |||
|
|
|||
| <td> | |||
| (unsupported) | |||
| Arrays will be _stringified_ and stored as strings. In the case of OpenTelemetry logs, | |||
There was a problem hiding this comment.
I don't think we should be using the verb stringify in our pub docs, I'd rephrase it as: "Arrays will be converted to text ..."
WriteMayur
reviewed
Mar 10, 2025
| @@ -461,7 +461,8 @@ Attributes may be of any of the following types: | |||
| </td> | |||
|
|
|||
| <td> | |||
| (unsupported) | |||
| Arrays will be _stringified_ and stored as strings. In the case of OpenTelemetry logs, | |||
There was a problem hiding this comment.
Suggestion:
Suggested change
| Arrays will be _stringified_ and stored as strings. In the case of OpenTelemetry logs, | |
| Arrays are converted to strings and then stored. OpenTelemetry logs support |
WriteMayur
reviewed
Mar 10, 2025
| @@ -461,7 +461,8 @@ Attributes may be of any of the following types: | |||
| </td> | |||
|
|
|||
| <td> | |||
| (unsupported) | |||
| Arrays will be _stringified_ and stored as strings. In the case of OpenTelemetry logs, | |||
| homogeneous arrays are supported. For more information see [arrays in OpenTelemetry](/docs/nrql/using-nrql/arrays-in-nrql/). | |||
There was a problem hiding this comment.
Suggested change
| homogeneous arrays are supported. For more information see [arrays in OpenTelemetry](/docs/nrql/using-nrql/arrays-in-nrql/). | |
| homogeneous arrays. For more information see [arrays in OpenTelemetry](/docs/nrql/using-nrql/arrays-in-nrql/). |
WriteMayur
added
content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've never clarified the difference in array processing between opentelemetry and the rest of ingestion mechanisms.
This PR aims to fix that.
Bascially, we stringify all arrays except for Opentelemetry homogeneous (one type) arrays.