Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nr-control): authentication #20130

Open
wants to merge 1 commit into
base: NR-336364-nr-control-pp-docs
Choose a base branch
from

Conversation

rubenruizdegauna
Copy link
Contributor

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

The objective of this PR is adding an overview of L1/L2 Autentication process

Copy link

github-actions bot commented Mar 4, 2025

Hi @rubenruizdegauna 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

is authenticated and coming from a verified source.

Agent Control must have a valid `L2 System Identity` and use it to sign all requests. L2 System Identities do not
expire and can be used throughout the lifecycle of Agent Control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can they be revoked/rotated?

For sure we recreate one if you delete the secret, but I am not sure whether you can marked as invalid an old one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question 🤔 I know that it can be done through NerdGraph, but I'm not sure about the permissions required. I asked and tagged you in the question.

...
```

### L1 Entities Expiration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would point of that the job it leverages that only at installation time, but you can upgrade without issues with an expired key. (Is it the same for onHost?)

@WriteMayur WriteMayur requested a review from ubanerjeeNR March 10, 2025 09:30
@WriteMayur WriteMayur added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 10, 2025
@rubenruizdegauna rubenruizdegauna force-pushed the feat_agent_control_authentication branch from b737877 to 967ab41 Compare March 10, 2025 09:41
@rubenruizdegauna rubenruizdegauna changed the title feat(nr-control): L1/L2 authentication feat(nr-control): authentication Mar 10, 2025
@rubenruizdegauna rubenruizdegauna marked this pull request as ready for review March 10, 2025 09:42
@rubenruizdegauna rubenruizdegauna force-pushed the feat_agent_control_authentication branch from 967ab41 to 433111a Compare March 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants