-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to the NRQL predictions and PREDICT syntax docs #20086
update to the NRQL predictions and PREDICT syntax docs #20086
Conversation
|
Hi @maprahamianNR 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use the `USING` keyword to specify the amount of historical data you want to use to train the model. For example, `PREDICT USING 1 day` uses the query window along with the data from the preceding day to train the model. Make sure the time span is an `integer unit` of time. | ||
amount of time. | ||
</Collapser> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the `USING` keyword to specify the amount of historical data you want to use to train the model. For example, `PREDICT USING 1 day` uses the query window along with the data from the preceding day to train the model. Make sure the time span is an `integer unit` of time. | |
amount of time. | |
</Collapser> | |
Use the `USING` keyword to specify the amount of historical data you want to use to train the model. For example, `PREDICT USING 1 day` uses the query window along with the data from the preceding day to train the model. Make sure the time span is an `integer unit` of time. | |
</Collapser> |
nit
<td>`NONE`</td> | ||
<td> | ||
Disables the seasonality of the time series and generates a non-seasonal prediction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note/callout here that NONE
is mutually exclusive with gamma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, if you use seasonality: NONE
and then include a value for gamma
, the model just ignores whatever value you provide for gamma
since it is never used. But I don't believe it will error or anything if you included it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm we are seeing errors. I have not investigated yet, but currently we are seeing our generic wrapper for IllegalArgumentException
from baselines being returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct, that is my mistake. If you set seasonality: NONE
and try to set a value for gamma
, it will error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
</Collapser> | ||
|
||
<Collapser id="by" title={<>Add the <InlineCode>BY</InlineCode> keyword.</>}> | ||
Use the `BY` keyword to set how far ahead in time you want the model to predict. For example, `PREDICT BY 3 hours` generates a prediction 3 hours into the future from the latest point in the time series. Make sure, the time span is an `integer unit` of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comma after "Make sure" not needed.
* **Lower value**: More damping effect to the prediction curve that gradually levels out to a flat curve. | ||
* **Higher value**: Lesser damping effect to the prediction curve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: All the others have higher before lower. Can we use the same ordering for all for consistency? Since the lower value explanation in this section has more detail, I would be in favor of putting lower in first for all the hyperparams.
@@ -117,7 +117,7 @@ Currently, <DNT>**NRQL predictions**</DNT> only supports the <DNT>**Holt-Winters | |||
|
|||
## Default behavior [#defaults] | |||
The `PREDICT` clause in a query comes with the following default behaviors: | |||
* **Seasonality**: Automatically detects and identifies if the data exhibits any seasonality. | |||
* **Seasonality**: Automatically detects and identifies any seasonality in the data, allowing you to configure forecasts to follow the identified pattern or remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better worded as: "Automatically detects if seasonality is present in the data and if seasonality is present, uses the detected season length to construct the predictive model. If no seasonality is detected, a non-seasonal model is used."
|
||
```sql | ||
FROM Transaction SELECT count(*) WHERE error IS TRUE TIMESERIES PREDICT holtwinters(beta: 0.5) BY 3 hours USING 1 day | ||
#### Customization [#customization] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the `USING` keyword to specify the amount of historical data you want to use to train the model. For example, `PREDICT USING 1 day` uses the query window along with the data from the preceding day to train the model. Make sure the time span is an `integer unit` of time. | ||
amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the `USING` keyword to specify the amount of historical data you want to use to train the model. For example, `PREDICT USING 1 day` uses the query window along with the data from the preceding day to train the model. Make sure the time span is an `integer unit` of time. | |
amount of time. | |
Use the `USING` keyword to specify the amount of historical data you want to use to train the model. For example, `PREDICT USING 1 day` uses the query window along with the data from the preceding day to train the model. Make sure the time span is an `integer unit` of time. |
nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates some of the information about the new NRQL Predictions functionality (i.e. the
PREDICT
clause along with the details about its usage). The 2 pages being updated are:Many of the technical details about the new functionality were incorrect and not explained well for a new user to understand.
Additionally, the 2 images used as examples of the predictions functionality are very poor examples that don't do a good job at demonstrating what the feature does.