Improve AC DOCS: add migration guide and fix indentation #20049
Conversation
|
Hi @paologallinaharbur 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
paologallinaharbur
force-pushed
the
feat/discovery
branch
from
8809916 to
3fff8da
Compare
| # Values related to the agent control's Helm chart release. | ||
| # `https://github.com/newrelic/helm-charts/blob/master/charts/agent-control/values.yaml` | ||
| agent-control-deployment: | ||
| identityClientId: "" |
There was a problem hiding this comment.
Should we specify here that these 2 fields are required or the chart won't install?
|
|
||
| In particular you can deploy and manage through the Agent Control: | ||
| - Most of the Helm Charts included in the `nri-bundle` chart: | ||
| - `newrelic-infrastructure`, `nri-kube-events`, `kube-state-metrics`, and `nri-kube-events` now managed through the New Relic Infrastructure AgentType. |
There was a problem hiding this comment.
Maybe adding here a link to what is an agent_type, do we have that?
There was a problem hiding this comment.
I think that should be addressed in the main PR
| Start the [Agent Control Installation](/docs/new-relic-control/agent-control/setup/) via Guided install and select all the agents you are interested in. | ||
| Copy locally the `values.yaml`, and before applying it change each Agent config to match the one of the Agents already running in the cluster. | ||
|
|
||
| ### Disinstall the agents you want to migrate |
There was a problem hiding this comment.
I don't know if Disinstall is correct, but isn't Uninstall or Deinstall more commonly used?
There was a problem hiding this comment.
I reused the old
Give us some context
The objective of this PR is adding a migration guide.
On the way I removed the manual installation step to step flow and fixed the indentation
I'd like to add @ubanerjeeNR as a reviewer but I do not have enough powers to do so