Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed errant brace in ObjectAPI Error #7192

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

michaelrogers
Copy link
Contributor

@michaelrogers michaelrogers commented Oct 31, 2023

Describe your changes:

Removed the trailing brace in an Error from the Object API.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@michaelrogers michaelrogers changed the title Removed errant brace in Error Removed errant brace in ObjectAPI Error Oct 31, 2023
@deploysentinel
Copy link

deploysentinel bot commented Oct 31, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/31/2023 02:08:51am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: d11f718

Started: 10/31/2023 02:03:04am UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/31/2023 02:08:51am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: d11f718

Started: 10/31/2023 02:02:14am UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
2.97% (3) 3 / 101 runs
failed over last 7 days
50.50% (51) 51 / 101 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
6.60% (7) 7 / 106 runs
failed over last 7 days
38.68% (41) 41 / 106 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
4.46% (5) 5 / 112 runs
failed over last 7 days
66.96% (75) 75 / 112 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7192 (d11f718) into master (c7fd584) will increase coverage by 0.45%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7192      +/-   ##
==========================================
+ Coverage   54.99%   55.45%   +0.45%     
==========================================
  Files         651      651              
  Lines       26192    26192              
  Branches     2536     2536              
==========================================
+ Hits        14405    14524     +119     
+ Misses      11085    10968     -117     
+ Partials      702      700       -2     
Flag Coverage Δ *Carryforward flag
e2e-full 41.79% <ø> (+<0.01%) ⬆️ Carriedforward from c7fd584
e2e-stable 57.34% <0.00%> (+4.06%) ⬆️
unit 48.91% <0.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/api/objects/ObjectAPI.js 92.27% <0.00%> (ø)

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7fd584...d11f718. Read the comment docs.

@unlikelyzero unlikelyzero merged commit a0fd1f0 into master Oct 31, 2023
@unlikelyzero unlikelyzero deleted the object-api-typo branch October 31, 2023 14:28
@unlikelyzero unlikelyzero added this to the Target:3.2.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants