fix: DisplayLayout and FlexibleLayout toolbar actions only apply to selected layout #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This negates the need for complicated logic in determining which objectView the action was intended for
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #7184 +/- ##
==========================================
- Coverage 59.97% 55.91% -4.07%
==========================================
Files 415 652 +237
Lines 12941 26187 +13246
Branches 0 2524 +2524
==========================================
+ Hits 7762 14643 +6881
- Misses 5179 10839 +5660
- Partials 0 705 +705
*This pull request uses carry forward flags. Click here to find out more.
... and 375 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/02/2023 08:42:12pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f58465d Started: 11/02/2023 08:40:41pm UTC Current Playwright Test Results Summary✅ 152 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/02/2023 08:42:12pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 2 • Retry 1 • Initial Attempt |
2.97% (3)3 / 101 runsfailed over last 7 days |
53.47% (54)54 / 101 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
5.36% (6)6 / 112 runsfailed over last 7 days |
37.50% (42)42 / 112 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
6.60% (7)7 / 106 runsfailed over last 7 days |
35.85% (38)38 / 106 runsflaked over last 7 days |
📄 functional/planning/ganttChart.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Gantt Chart Can select a single activity and display its details in the inspector
Retry 1 • Initial Attempt |
0.70% (1)1 / 143 runfailed over last 7 days |
0.70% (1)1 / 143 runflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
5.59% (8)8 / 143 runsfailed over last 7 days |
51.05% (73)73 / 143 runsflaked over last 7 days |
📄 functional/plugins/flexibleLayout/flexibleLayout.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Flexible Layout items in a flexible layout can be removed with object tree context menu when viewing the flexible layout
Retry 1 • Initial Attempt |
0% (0)0 / 129 runsfailed over last 7 days |
0.78% (1)1 / 129 runflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
3.57% (4)4 / 112 runsfailed over last 7 days |
66.96% (75)75 / 112 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0% (0)0 / 112 runsfailed over last 7 days |
4.46% (5)5 / 112 runsflaked over last 7 days |
scottbell
reviewed
Oct 31, 2023
scottbell
reviewed
Oct 31, 2023
scottbell
reviewed
Oct 31, 2023
utilizing localStorage in e2e
scottbell
reviewed
Nov 2, 2023
scottbell
approved these changes
Nov 2, 2023
ozyx
added a commit
that referenced
this pull request
Nov 2, 2023
…ions only apply to selected layout * refactor: convert to ES6 function * fix: include `keyString` in event name - This negates the need for complicated logic in determining which objectView the action was intended for * fix: handle the case of currentView being null * fix: add keyString to flexibleLayout toolbar events * fix: properly unregister listeners * fix: remove unused imports * fix: revert parameter reorder * refactor: replace usage of `arguments` with `...args` * fix: add a11y to display layout + toolbar * test: add first cut of layout toolbar suite * test: cleanup a bit and add Image test * test: add stubs * fix: remove unused variable * refactor(DisplayLayoutToolbar): convert to ES6 class * test: generate localStorage data for display layout tests * fix: clarify "Add" button label * test: cleanup and don't parameterize tests * test: fix path for recycled_local_storage.json * fix: path to local storage file * docs: add documentation for utilizing localStorage in e2e * fix: path to recycled_local_storage.json * docs: add note hyperlink
ozyx
added a commit
that referenced
this pull request
Nov 3, 2023
…ions only apply to selected layout * refactor: convert to ES6 function * fix: include `keyString` in event name - This negates the need for complicated logic in determining which objectView the action was intended for * fix: handle the case of currentView being null * fix: add keyString to flexibleLayout toolbar events * fix: properly unregister listeners * fix: remove unused imports * fix: revert parameter reorder * refactor: replace usage of `arguments` with `...args` * fix: add a11y to display layout + toolbar * test: add first cut of layout toolbar suite * test: cleanup a bit and add Image test * test: add stubs * fix: remove unused variable * refactor(DisplayLayoutToolbar): convert to ES6 class * test: generate localStorage data for display layout tests * fix: clarify "Add" button label * test: cleanup and don't parameterize tests * test: fix path for recycled_local_storage.json * fix: path to local storage file * docs: add documentation for utilizing localStorage in e2e * fix: path to recycled_local_storage.json * docs: add note hyperlink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7176
Describe your changes:
keyStringto the event name emitted by toolbar context actions to uniquely apply the action against the selected objectAll Submissions:
Author Checklist
Reviewer Checklist