Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltips] Finish tests for gauges, telemetry tables, recently viewed items, and time strips #7145

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

khalidadil
Copy link
Contributor

Closes #7142

Describe your changes:

Added tests for gauges, telemetry tables, recently viewed items, and time strips

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@khalidadil khalidadil linked an issue Oct 14, 2023 that may be closed by this pull request
@@ -226,7 +226,7 @@
</template>

<template v-if="typeMeter">
<div class="c-meter">
<div class="c-meter" @mouseover.ctrl="showToolTip" @mouseleave="hideToolTip">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tooltips for meter gauges

@deploysentinel
Copy link

deploysentinel bot commented Oct 14, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 10:06:25pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 2079ad1

Started: 10/24/2023 10:03:07pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 10:06:25pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 2079ad1

Started: 10/24/2023 10:00:17pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
4% (3) 3 / 75 runs
failed over last 7 days
20% (15) 15 / 75 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
7.69% (6) 6 / 78 runs
failed over last 7 days
48.72% (38) 38 / 78 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
2.53% (2) 2 / 79 runs
failed over last 7 days
68.35% (54) 54 / 79 runs
flaked over last 7 days

View Detailed Build Results


@khalidadil khalidadil requested a review from davetsay October 14, 2023 06:50
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Oct 17, 2023
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #7145 (dd433d2) into master (13311b9) will decrease coverage by 13.95%.
The diff coverage is n/a.

❗ Current head dd433d2 differs from pull request most recent head 2079ad1. Consider uploading reports for the commit 2079ad1 to get more accurate results

@@             Coverage Diff             @@
##           master    #7145       +/-   ##
===========================================
- Coverage   55.77%   41.83%   -13.95%     
===========================================
  Files         651      414      -237     
  Lines       26187    12923    -13264     
  Branches     2535        0     -2535     
===========================================
- Hits        14607     5406     -9201     
+ Misses      10881     7517     -3364     
+ Partials      699        0      -699     
Flag Coverage Δ
e2e-full 41.83% <ø> (+0.07%) ⬆️
e2e-stable ?
unit ?

see 523 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13311b9...2079ad1. Read the comment docs.

@davetsay davetsay added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 24, 2023
@khalidadil khalidadil enabled auto-merge (squash) October 24, 2023 22:05
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 24, 2023
@khalidadil khalidadil merged commit 8f92cd4 into master Oct 24, 2023
@khalidadil khalidadil deleted the tests/issue-7142 branch October 24, 2023 22:06
@unlikelyzero unlikelyzero added this to the Target:3.2.0 milestone Nov 13, 2023
await page.dragAndDrop(`text=${sineWaveObject3.name}`, '.c-gauge__wrapper');
await page.keyboard.down('Control');
// eslint-disable-next-line playwright/no-force-option
await page.locator('.c-gauge.c-dial').hover({ position: { x: 0, y: 0 }, force: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing tests for tooltips to cover missed cases
4 participants