cherry-pick(#7088): [Staleness] Fix staleness on clock change #7112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update staleness mixin * Fix listeners and add guard * Add check to make sure staleness only shows for correct clock * Add guard for time api * Cleanup the setting of isStale in ObjectView * Cleanup use of combinedKey on LadTableSet
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/04/2023 08:58:01pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 8985a0c Started: 10/04/2023 08:53:22pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
2.04% (1)1 / 49 runfailed over last 7 days |
8.16% (4)4 / 49 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 141 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 10/04/2023 08:58:01pm UTC)
⚠️ Flakes
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
7.53% (7)7 / 93 runsfailed over last 7 days |
48.39% (45)45 / 93 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 84 runsfailed over last 7 days |
40.48% (34)34 / 84 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 131 runsfailed over last 7 days |
56.49% (74)74 / 131 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
17.35% (17)17 / 98 runsfailed over last 7 days |
54.08% (53)53 / 98 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6339
All Submissions:
Author Checklist
Reviewer Checklist