Remove large series models from reactive data in plots #6961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eries-models-from-reactive-data-in-plots
This reverts commit 6978b34.
…eries-models-from-reactive-data-in-plots
scottbell
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6961 +/- ##
==========================================
- Coverage 55.72% 55.66% -0.06%
==========================================
Files 643 643
Lines 25726 25786 +60
Branches 2512 2517 +5
==========================================
+ Hits 14335 14354 +19
- Misses 10692 10736 +44
+ Partials 699 696 -3
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/06/2023 07:51:09am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: a8fb727 Started: 09/06/2023 07:48:08am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2 • Retry 1 • Initial Attempt |
17.07% (7)7 / 41 runsfailed over last 7 days |
21.95% (9)9 / 41 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 138 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 09/06/2023 07:51:09am UTC)
⚠️ Flakes
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.30% (2)2 / 87 runsfailed over last 7 days |
42.53% (37)37 / 87 runsflaked over last 7 days |
📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Plot Tagging Tags work with Overlay Plots
Retry 2 • Retry 1 • Initial Attempt |
9.20% (8)8 / 87 runsfailed over last 7 days |
26.44% (23)23 / 87 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0.85% (1)1 / 118 runfailed over last 7 days |
44.92% (53)53 / 118 runsflaked over last 7 days |
…ive-data-in-plots
ozyx
suggested changes
Aug 21, 2023
…ive-data-in-plots
…ive-data-in-plots
…ive-data-in-plots
…ive-data-in-plots
…ive-data-in-plots
…ive-data-in-plots
…ive-data-in-plots
…ive-data-in-plots
shefalijoshi
approved these changes
Sep 6, 2023
shefalijoshi
requested changes
Sep 6, 2023
shefalijoshi
approved these changes
Sep 6, 2023
shefalijoshi
deleted the
6879-remove-large-series-models-from-reactive-data-in-plots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6879
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist