-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#6854): [LADTableSet] prevent compositions from becoming reactive #6855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 48.16% 48.19% +0.02%
==========================================
Files 643 643
Lines 25618 25619 +1
Branches 2507 2507
==========================================
+ Hits 12340 12347 +7
+ Misses 12801 12795 -6
Partials 477 477
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/28/2023 07:18:34pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 6f48efa Started: 07/28/2023 07:16:38pm UTC Current Playwright Test Results Summary✅ 131 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/28/2023 07:18:34pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2 • Retry 1 • Initial Attempt |
12.07% (7)7 / 58 runsfailed over last 7 days |
29.31% (17)17 / 58 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Good catch!
Closes #6854
Describe your changes:
Declare and initialize
this.compositions
in thecreated()
hook rather thandata()
so that objects added to it do not become reactive, and thus can access their own private class methods.All Submissions:
Author Checklist
Reviewer Checklist