Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix couchdb e2e trigger and run nightly, part 3 #6782

Merged
merged 6 commits into from
Jul 8, 2023

Conversation

unlikelyzero
Copy link
Contributor

@unlikelyzero unlikelyzero commented Jul 7, 2023

Describe your changes:

  • Fixes the pr:e2e:couchdb trigger to register more frequently
  • Updates the workflows to run on pushes to master and nightly
  • Driveby: reduce confusion with the github annotation reporter

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@@ -77,7 +77,6 @@ const config = {
}
],
['junit', { outputFile: '../test-results/results.xml' }],
['github'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driveby: this causes too much confusion

@deploysentinel
Copy link

deploysentinel bot commented Jul 7, 2023

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/07/2023 08:21:56pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 2d1dca8

Started: 07/07/2023 08:17:10pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
7.14% (1) 1 / 14 run
failed over last 7 days
78.57% (11) 11 / 14 runs
flaked over last 7 days

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2Retry 1Initial Attempt
0% (0) 0 / 14 runs
failed over last 7 days
21.43% (3) 3 / 14 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #6782 (dd9bfe2) into master (3b0e05e) will increase coverage by 0.54%.
The diff coverage is n/a.

❗ Current head dd9bfe2 differs from pull request most recent head 4cd56e4. Consider uploading reports for the commit 4cd56e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #6782      +/-   ##
==========================================
+ Coverage   53.87%   54.42%   +0.54%     
==========================================
  Files         624      396     -228     
  Lines       24848    12067   -12781     
  Branches     2493        0    -2493     
==========================================
- Hits        13386     6567    -6819     
+ Misses      10794     5500    -5294     
+ Partials      668        0     -668     
Flag Coverage Δ *Carryforward flag
e2e-full 42.27% <ø> (ø) Carriedforward from aeae1cb
e2e-stable 50.81% <ø> (-4.74%) ⬇️
unit ?

*This pull request uses carry forward flags. Click here to find out more.

see 412 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0e05e...4cd56e4. Read the comment docs.

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 7, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 7, 2023
@unlikelyzero unlikelyzero merged commit 9c22bcf into master Jul 8, 2023
@unlikelyzero unlikelyzero deleted the fix-couchdb-trigger branch July 8, 2023 20:03
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants