Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and Link dialog's Locator is way too small #6654

Closed
2 of 7 tasks
charlesh88 opened this issue May 10, 2023 · 4 comments · Fixed by #6663
Closed
2 of 7 tasks

Move and Link dialog's Locator is way too small #6654

charlesh88 opened this issue May 10, 2023 · 4 comments · Fixed by #6663
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Milestone
Target:2.2.4

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented May 10, 2023 •
edited
Loading

Summary

The Move and Link dialogs are using a different form builder configuration that doesn't size the Locator properly; it should be the same as the one used in Save and Duplicate.

Move/Duplicate
image

Save/Save As...
image

Expected vs Current Behavior

Steps to Reproduce

  1. Use the Move or Duplicate action on an object.
  2. Observe the resulting dialog's Locator element.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@charlesh88 charlesh88 self-assigned this May 10, 2023
@charlesh88
Copy link
Contributor Author

charlesh88 commented May 10, 2023 •
edited
Loading

Testing Notes

  1. See steps to reproduce above.
  2. Make sure your browser window is large enough vertically such that the Locator can expand as shown below.
  3. Verify that Move and Create Link dialogs look like reference images below.

Move
Screen Shot 2023-05-12 at 9 24 47 AM

Create Link
Screen Shot 2023-05-12 at 9 25 05 AM

@charlesh88 charlesh88 added the bug:regression It used to work. Now it doesn't :( label May 10, 2023
charlesh88 added a commit that referenced this issue May 12, 2023
@charlesh88
Closes #6654
ac5c64c 
- Corrected form builder configurations.
@charlesh88 charlesh88 changed the title Move/duplicate dialog's Locator is way too small Move and Link dialog's Locator is way too small May 12, 2023
@charlesh88 charlesh88 mentioned this issue May 12, 2023
Merged
15 tasks
ozyx pushed a commit that referenced this issue May 16, 2023
@charlesh88
Fix Locator in Move and Link dialogs (#6663)
225fa22 
Closes #6654
- Corrected form builder configurations.
@ozyx ozyx added this to the Target:2.2.4 milestone May 16, 2023
@charlesh88
Copy link
Contributor Author

Testathon 2023-05-30 verified fixed.

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 05/30/23

@rukmini-bose
Copy link
Contributor

Testathon Verified 5/30/2023 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Projects
None yet
Milestone
Target:2.2.4
Development

Successfully merging a pull request may close this issue.

Fix Locator in Move and Link dialogs nasa/openmct
5 participants
@charlesh88 @khalidadil @ozyx @unlikelyzero @rukmini-bose