fix(core): Ensure worker stops picking up new jobs while shutting down #13714
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
netroy
approved these changes
Mar 10, 2025
|
|
n8n
|
||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-693-worker-shutdown-works-incorrectly
|
| Run status |
|
| Run duration | 04m 32s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
364
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
39-projects.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Projects > when starting from scratch > should move resources between projects |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 30 specs in Cypress Cloud.
|
|
1 similar comment
|
|
|
This PR needs latest master to be merged, to fix the e2e tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On
masterwe currently pause the queue on shutdown only for main, i.e. the worker continues to pick up jobs during shutdown which are likely to be interrupted by the 30s shutdown timeout. This PR ensures the worker stops dequeuing jobs during shutdown.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-693/worker-shutdown-works-incorrectly
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)