Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dispatch error when endpoint promise fails to provide a string #151

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

decepulis
Copy link
Contributor

No description provided.

@decepulis decepulis requested a review from a team as a code owner February 18, 2025 20:33
@decepulis decepulis marked this pull request as draft February 18, 2025 20:36
@decepulis decepulis marked this pull request as ready for review February 18, 2025 20:58
Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick scan of the codebase to see if there were any other concerns/considerations, but didn't notice any. LGTM! 🚢 🇮🇹

@decepulis decepulis merged commit 4dabce2 into muxinc:master Feb 19, 2025
3 checks passed
@decepulis decepulis mentioned this pull request Feb 19, 2025
decepulis added a commit to decepulis/elements that referenced this pull request Feb 19, 2025
to [v3.5.0](https://github.com/muxinc/upchunk/releases/tag/v3.5.0)
- fix: handle edge case for resuming chunk upload case where multiple chunks have previously been uploaded. by @cjpillsbury in [muxinc#141](muxinc/upchunk#141)
- feat: dispatch error when endpoint promise fails to provide a string by @decepulis in [muxinc#151](muxinc/upchunk#151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants