Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build fail on MS Windows #42

Closed
Raerten opened this issue Jan 9, 2018 · 4 comments
Closed

build fail on MS Windows #42

Raerten opened this issue Jan 9, 2018 · 4 comments
Labels
bug pr-merged

Comments

@Raerten
Copy link
Contributor

Raerten commented Jan 9, 2018

build fail on MS Windows

.\main.go:282:14: undefined: pty.Start
.\main.go:290:31: not enough arguments in call to syscall.Syscall
.\main.go:290:32: undefined: syscall.SYS_IOCTL
.\main.go:290:67: undefined: syscall.TIOCSWINSZ

Compilation finished with exit code 2

go version go1.9.2 windows/amd64, win 10 Pro
moul added a commit that referenced this issue Feb 28, 2018
@moul
do not use pty on windows for compatiblity (#42)
227b64a
@moul
Copy link
Owner

moul commented Feb 28, 2018

Hi @Raerten

I fixed your first problem (PTY) in this branch: https://github.com/moul/sshportal/compare/dev/moul/support-windows?expand=1

However, I now have a new building problem that seems to be already known by the community: mattn/go-sqlite3#27

$ GOOS=windows go build -v -i -o tmp .
github.com/moul/sshportal/vendor/github.com/mattn/go-sqlite3
# github.com/moul/sshportal/vendor/github.com/mattn/go-sqlite3
../../../go/src/github.com/moul/sshportal/vendor/github.com/mattn/go-sqlite3/sqlite3_go18.go:18:10: undefined: SQLiteConn

Is this an option for you to run sshportal in Linux, for instance using a VM or just "Docker for Windows" which supports Linux binary very nicely

@moul moul added the bug label Feb 28, 2018
@Raerten Raerten mentioned this issue Nov 15, 2018
Merged
@Raerten
Copy link
Contributor Author

Raerten commented Nov 15, 2018

hi @moul
I add PR that fix logs path and filename on Windows.
Now Windows build pass and it work's well.

@moul
Copy link
Owner

moul commented Nov 18, 2018

@Raerten can you update me about what's the current state on windows?

@Raerten
Copy link
Contributor Author

Raerten commented Nov 19, 2018

@moul
I added PR #97. With this path the branch dev/moul/support-windows builds on Windows and it works well.

@moul moul mentioned this issue Nov 25, 2018
Merged
@helpr helpr bot added the pr-available label Nov 25, 2018
@moul moul closed this as completed in #101 Nov 25, 2018
@helpr helpr bot added pr-merged and removed pr-available labels Nov 25, 2018
systemmonkey42 pushed a commit to systemmonkey42/sshportal that referenced this issue Feb 25, 2025
@dependabot
chore(deps): bump the go-deps group with 6 updates (moul#42)
e3727d3 
Bumps the go-deps group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/docker/docker](https://github.com/docker/docker) | `26.1.3+incompatible` | `27.0.2+incompatible` |
| [golang.org/x/crypto](https://github.com/golang/crypto) | `0.23.0` | `0.24.0` |
| [golang.org/x/tools](https://github.com/golang/tools) | `0.21.0` | `0.21.1-0.20240508182429-e35e4ccd0d2d` |
| [gorm.io/driver/mysql](https://github.com/go-gorm/mysql) | `1.5.6` | `1.5.7` |
| [gorm.io/driver/postgres](https://github.com/go-gorm/postgres) | `1.5.7` | `1.5.9` |
| [gorm.io/driver/sqlite](https://github.com/go-gorm/sqlite) | `1.5.5` | `1.5.6` |


Updates `github.com/docker/docker` from 26.1.3+incompatible to 27.0.2+incompatible
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v26.1.3...v27.0.2)

Updates `golang.org/x/crypto` from 0.23.0 to 0.24.0
- [Commits](golang/crypto@v0.23.0...v0.24.0)

Updates `golang.org/x/tools` from 0.21.0 to 0.21.1-0.20240508182429-e35e4ccd0d2d
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/commits)

Updates `gorm.io/driver/mysql` from 1.5.6 to 1.5.7
- [Commits](go-gorm/mysql@v1.5.6...v1.5.7)

Updates `gorm.io/driver/postgres` from 1.5.7 to 1.5.9
- [Commits](go-gorm/postgres@v1.5.7...v1.5.9)

Updates `gorm.io/driver/sqlite` from 1.5.5 to 1.5.6
- [Commits](go-gorm/sqlite@v1.5.5...v1.5.6)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: go-deps
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-deps
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-deps
- dependency-name: gorm.io/driver/mysql
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-deps
- dependency-name: gorm.io/driver/postgres
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-deps
- dependency-name: gorm.io/driver/sqlite
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-deps
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pr-merged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moul @Raerten