-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(POC) GODRIVER-3444 Adjust getMore maxTimeMS Calculation for tailable awaitData Cursors #1925
Draft
prestonvasquez
wants to merge
10
commits into
mongodb:master
Choose a base branch
from
prestonvasquez:GODRIVER-3444
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,017
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
API Change ReportNo changes found! |
…iver into GODRIVER-3444
matthewdale
reviewed
Feb 28, 2025
@@ -30,3 +37,35 @@ const ( | |||
UpdateOp = "update" // UpdateOp is the name for updating | |||
BulkWriteOp = "bulkWrite" // BulkWriteOp is the name for client-level bulk write | |||
) | |||
|
|||
func CalculateMaxTimeMS(ctx context.Context, rttMin time.Duration, rttStats string, err error) (int64, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unconventional to pass the error to be returned in as a parameter. Instead, consider letting CalculateMaxTimeMS
return just the int64
value, and let the caller form the error value.
E.g. use in batch_cursor.go
:
maxTimeMS = driverutil.CalculateMaxTimeMS(ctx, rttMonitor.Min())
if maxTimeMS <= 0 {
return nil, fmt.Errorf(
"calculated server-side timeout (%v ms) is less than or equal to 0 (%v): %w",
maxTimeMS,
rttMonitor.Stats(),
ErrDeadlineWouldBeExceeded)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3444
Summary
If
maxAwaitTime
option is set, use themin(maxAwaitTimeMS, remaining timeoutMS)
as themaxTimeMS
field on getMore commands.Background & Motivation
From the DRIVERS-2868 proposal: