Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return non-nil result when calling exec with empty query #973

Merged
merged 1 commit into from
Oct 19, 2021
Merged

return non-nil result when calling exec with empty query #973

merged 1 commit into from
Oct 19, 2021

Conversation

avivklas
Copy link
Contributor

@avivklas avivklas commented Oct 19, 2021 •
edited
Loading

Proposed changes

  • fixed exec to always return driver.Result even when there's nothing to actually run
  • added test for calling exec with empty statement

fixes #963

@mattn
Copy link
Owner

mattn commented Oct 19, 2021

LGTM

@mattn mattn merged commit 3900dc3 into mattn:master Oct 19, 2021
@mattn
Copy link
Owner

mattn commented Oct 19, 2021

Thank you

@avivklas avivklas deleted the exec_empty_query branch February 28, 2023 11:06
@ganigeorgiev ganigeorgiev mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is this a bug in the database/sql layer? Panic on Exec of empty string
2 participants
@avivklas @mattn