Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil slice to zero-length blob #542

Closed
lucasmrod opened this issue Mar 24, 2018 · 1 comment
Closed

nil slice to zero-length blob #542

lucasmrod opened this issue Mar 24, 2018 · 1 comment
Labels

Comments

@lucasmrod
Copy link
Contributor

Changes to fix #424 also make nil slice be converted to zero-length blob. Instead, nil slice should be converted to value NULL.

Current code:
	[]byte -> zero length blob
	nil    -> zero length blob
Proposal:
	[]byte -> zero length blob
	nil    -> NULL blob

I can submit a PR if the proposal makes sense to you.

@gjrtimmer
Copy link
Collaborator

@lucasmrod makes sense, can you submit a PR of evaluation and testing, please also include tests in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants