Migrate to GitHub Actions #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 27 27
Lines 2073 2073
=======================================
Hits 1748 1748
Misses 212 212
Partials 113 113Continue to review full report at Codecov.
|
vishr
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
This PR closes #1465.
Changes
Added
.github/workflows/echo.ymlfile to enable GitHub Actions. The current implementation has the following steps running onUbuntu,macOS, andWindows:1.11,1.12, and1.13.codecov.io. This feature is currently incomplete as I do not have this repository'scodecovtoken. I anticipate a discussion where we would discuss just putting the token in plain text for the world to see but this is what we need to do. If, for example, we create a secret and access that secret within the workflow, this secret would ONLY be accessible for builds running in this repository. If a user has forked this repository, this token won't be passed down to them. This would make it impossible for those users to check for coverage before making a PR. If we are comfortable with this behavior, we can use the secret too. If not, either send me the token or feel free to make a commit and paste the token on line 52.[OPTIONAL] Creating a release. GitHub Actions also support creating automated releases. If this is something we are interested in, we can work on a method to generate the release notes and have the automated release step implemented. How it would work is that every time a tag is pushed, the release step would be executed creating a new release.
For a sample output of the workflow, please head over to: https://github.com/asahasrabuddhe/echo/actions