Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kops-ci references #16764

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Drop kops-ci references #16764

merged 1 commit into from
Aug 23, 2024

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 21, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2024
@ameukam
Copy link
Member Author

ameukam commented Aug 21, 2024

cc @hakman @rifelpet

@hakman
Copy link
Member

hakman commented Aug 21, 2024

To merge this I think we have to merge #16755 first and skip all failing tests...
/cc @justinsb @rifelpet
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@ameukam
Copy link
Member Author

ameukam commented Aug 23, 2024

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-aws-cilium
/override pull-kops-e2e-k8s-aws-ipalias

@k8s-ci-robot
Copy link
Contributor

@ameukam: ameukam unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-aws-cilium
/override pull-kops-e2e-k8s-aws-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Aug 23, 2024

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-aws-cilium
/override pull-kops-e2e-k8s-aws-ipalias

@k8s-ci-robot
Copy link
Contributor

@hakman: hakman unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-aws-cilium
/override pull-kops-e2e-k8s-aws-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Aug 23, 2024

@justinsb Can you give it a try?

@justinsb
Copy link
Member

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-aws-cilium
/override pull-kops-e2e-k8s-aws-ipalias

@k8s-ci-robot
Copy link
Contributor

@justinsb: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • pull-kops-e2e-k8s-aws-cilium
  • pull-kops-e2e-k8s-aws-ipalias

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-linux-amd64
  • build-macos-amd64
  • build-windows-amd64
  • deploy/netlify
  • pull-kops-build
  • pull-kops-e2e-k8s-aws-amazonvpc
  • pull-kops-e2e-k8s-aws-calico
  • pull-kops-e2e-k8s-gce-cilium
  • pull-kops-e2e-k8s-gce-ipalias
  • pull-kops-kubernetes-e2e-ubuntu-gce-build
  • pull-kops-test
  • pull-kops-verify-boilerplate
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet
  • tide
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-aws-cilium
/override pull-kops-e2e-k8s-aws-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@justinsb
Copy link
Member

/override pull-kops-e2e-k8s-gce-cilium

/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@justinsb: Overrode contexts on behalf of justinsb: pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-gce-cilium

/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@justinsb
Copy link
Member

/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Contributor

@justinsb: Overrode contexts on behalf of justinsb: pull-kops-e2e-k8s-aws-calico

In response to this:

/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Aug 23, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit f03c40f into kubernetes:master Aug 23, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 23, 2024
@ameukam ameukam deleted the drop-kops-ci-ref branch December 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @hakman @k8s-ci-robot @justinsb