Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gce: Add option to use startup script instead of user-data #16705

Merged
merged 3 commits into from
Aug 9, 2024
Merged

gce: Add option to use startup script instead of user-data #16705

merged 3 commits into from
Aug 9, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 29, 2024 •
edited
Loading

Partial revert of #15607

Fixes #16697

/hold for feedback
/cc @justinsb @rifelpet @jsafrane

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane July 29, 2024 17:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/api area/provider/gcp Issues or PRs related to gcp provider labels Jul 29, 2024
@hakman hakman changed the title Add option for enabling GCE startup script gce: Add option for enabling GCE startup script Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2024
@hakman hakman force-pushed the gce-startup-script branch from e718931 to 599f97c Compare July 30, 2024 03:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2024
@hakman
Copy link
Member Author

hakman commented Aug 2, 2024

@justinsb could you take a look at this?

@jsafrane
Copy link
Member

jsafrane commented Aug 2, 2024 •
edited
Loading

I can confirm, this works for me:

kops create cluster jsafrane.mydomain.com --zones us-central1-a --state ${KOPS_STATE_STORE}/ --project=${PROJECT} --set=cluster.spec.cloudProvider.gce.startupScript=true --image=rocky-linux-cloud/rocky-linux-9-optimized-gcp-v20240717

@hakman
Copy link
Member Author

hakman commented Aug 9, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@hakman hakman requested a review from rifelpet August 9, 2024 16:41
@hakman
Copy link
Member Author

hakman commented Aug 9, 2024

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-ipalias

@hakman hakman changed the title gce: Add option for enabling GCE startup script gce: Add option to use startup script instead of user-data Aug 9, 2024
@justinsb
Copy link
Member

justinsb commented Aug 9, 2024

Awesome, thanks for fixing this!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2a1f1f2 into kubernetes:master Aug 9, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Aug 9, 2024
@rifelpet
Copy link
Member

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Aug 17, 2024
jsafrane added a commit to jsafrane/test-infra that referenced this pull request Aug 22, 2024
@jsafrane
Update presubmit SELinux job
d377b06 
Update the presubmit job to run on GCE.

Copies pull-kubernetes-e2e-gce-canary, adding just RHEL image + SELinux
feature gates.

kOps on GCE can now use RHEL: kubernetes/kops#16705
@jsafrane jsafrane mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

Installation fails on GCE + RHEL or Rocky Linux
5 participants
@hakman @jsafrane @justinsb @k8s-ci-robot @rifelpet