Fix getting crictl assets #16486
Fix getting crictl assets #16486
Conversation
because multiple crictl binaries are found when you specify containerd packages
k8s-ci-robot
added
cncf-cla: yes
|
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nodeup/pkg/model/crictl.go
Outdated
| return fmt.Errorf("unable to locate asset %q: %w", assetName, err) | ||
| assets := b.Assets.FindMatches(regexp.MustCompile(`^crictl$`)) | ||
| if len(assets) == 0 { | ||
| return fmt.Errorf("unable to find any crictl binaries in assets") |
There was a problem hiding this comment.
Having crictl (and maybe nerdctl also) installed is not exactly a blocker.
Could this be changed to warning and return early instead? Same thing below.
There was a problem hiding this comment.
I changed: ec47b3f
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
because multiple crictl binaries are found when you specify containerd packages. The old format containerd packages contain crictl binary.
Fix #16425