Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing too many pings one more time #737

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fixing too many pings one more time #737

merged 1 commit into from
Aug 16, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Aug 15, 2024

Closes #736

Adding an explicit guard for the too many ping bug.

@i3149 i3149 requested a review from jryburn August 15, 2024 22:18
@i3149
Copy link
Contributor Author

i3149 commented Aug 15, 2024

Was able to reproduce and validated this one is working so I'm confident here.

Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i3149 i3149 merged commit d431060 into main Aug 16, 2024
1 check passed
@i3149 i3149 deleted the guard-on-too-many-pings branch August 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopening packet loss on ping_only tests from issue732
2 participants