Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer/pickfirst/pickfirstleaf: fix race condition in tests #8148

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

chressie
Copy link
Contributor

@chressie chressie commented Mar 6, 2025

An upcoming change (go.dev/cl/653795) in the Go standard library
surfaces race conditions in these tests.

The race comes from the fact that a connectivity.Shutdown is
unconditionally recorded. This commit fixes this by adding a mutex to
guard access to the recorded states.

RELEASE NOTES: N/A

An upcoming change (go.dev/cl/653795) in the Go standard library
surfaces race conditions in these tests.

The race comes from the fact that a connectivity.Shutdown is
unconditionally recorded. This commit fixes this by adding a mutex to
guard access to the recorded states.
Copy link

linux-foundation-easycla bot commented Mar 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@arjan-bal arjan-bal added this to the 1.72 Release milestone Mar 6, 2025
@arjan-bal arjan-bal self-requested a review March 6, 2025 15:12
@arjan-bal arjan-bal self-assigned this Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (af07815) to head (ab24064).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8148      +/-   ##
==========================================
+ Coverage   82.30%   82.41%   +0.11%     
==========================================
  Files         392      392              
  Lines       39132    39132              
==========================================
+ Hits        32207    32251      +44     
+ Misses       5603     5571      -32     
+ Partials     1322     1310      -12     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjan-bal arjan-bal merged commit f49c747 into grpc:master Mar 6, 2025
15 checks passed
@chressie chressie deleted the race-fix branch March 6, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants