Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Enable dualstack flag #8134

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

arjan-bal
Copy link
Contributor

The flag was enabled in master as part of #8126. This PR enabled only the xDS endpoints support, leaving the new pickfirst policy flag disabled.

RELEASE NOTES:

  • xds: LB policies will receive additional addresses for endpoints which are specified in the additional_addresses field in the Endpoint message. The additional addresses will be present in the ResolverState.Endpoints passed to UpdateClientConnState method of the balancers. To disable this feature, set the environment variable GRPC_EXPERIMENTAL_XDS_DUALSTACK_ENDPOINTS to false (case insensitive).

@arjan-bal arjan-bal added this to the 1.71 Release milestone Feb 28, 2025
@arjan-bal arjan-bal added Type: Feature New features or improvements in behavior Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (bf0c885) to head (0620870).
Report is 1 commits behind head on v1.71.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.71.x    #8134      +/-   ##
===========================================
- Coverage    82.39%   82.25%   -0.15%     
===========================================
  Files          387      387              
  Lines        38954    38954              
===========================================
- Hits         32096    32041      -55     
- Misses        5554     5596      +42     
- Partials      1304     1317      +13     

see 19 files with indirect coverage changes

@easwars
Copy link
Contributor

easwars commented Feb 28, 2025

Why do we want to enable only one of the two flags?

@arjan-bal
Copy link
Contributor Author

Why do we want to enable only one of the two flags?

All petiole policies use the new pickfirst for delegation. The only user-visible benefit of toggling the default pickfirst would be enabling Happy Eyeballs with a standalone pickfirst. After discussing with Doug and Mark, we decided it's acceptable to advertise xDS Dualstack support without changing the default pickfirst since known xDS pickfirst users do not want to use Dualstack.

Most gRPC users rely on the default pickfirst. By delaying its adoption as the default to a future release, we allow time to gather feedback from internal users and those using the master branch.

@easwars easwars assigned arjan-bal and unassigned dfawley Feb 28, 2025
@arjan-bal arjan-bal merged commit 012f8bf into grpc:v1.71.x Mar 3, 2025
15 checks passed
@arjan-bal arjan-bal deleted the enable-xds-dualstack branch March 3, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants