cds: stop child policies on resource-not-found errors #8122
+114
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, when the cds LB policy received a resource-not-found error for one of the clusters that it was watching, it would do the following:
cluster_resolver
LB policy would then create a config with no priorities, and this would result in thepriority
LB policy putting the channel inTRANSIENT_FAILURE
and sending an error picker with a not so useful error message "all priorities are removed"With this change though, whenever the cds LB policy receives a resource-not-found (either from its parent or for the resources that it is watching), it will shut down the LB policy tree under it and put the channel in
TRANSIENT_FAILURE
. If the error is from its parent, the picker will fail with the error received from the parent. If the error is for one of the resources that the cds LB policy is watching, the error would be a more useful one "cluster foo not found".Addresses #7931.
RELEASE NOTES: