-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: Fix encoded message size reported in error message #8033
Conversation
4235952
to
ca0af15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an open issue that this fixes or did you just happen to notice this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8033 +/- ##
==========================================
+ Coverage 82.22% 82.27% +0.04%
==========================================
Files 383 382 -1
Lines 38688 38711 +23
==========================================
+ Hits 31813 31848 +35
+ Misses 5555 5547 -8
+ Partials 1320 1316 -4
|
For debugging #8023, I changed the type of BufferSlice from a slice to a struct. I was storing stack traces along with the BufSlice objects. This broke the build and I spotted this issue when fixing all the places that relied on BufSlice being a slice. |
This PR fixes two bugs in the encoded message size error message:
RELEASE NOTES: