balancer: Enforce embedding requirement for balancer.ClientConn #8026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: API Change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8026 +/- ##
==========================================
+ Coverage 82.29% 82.34% +0.04%
==========================================
Files 388 387 -1
Lines 39028 39037 +9
==========================================
+ Hits 32120 32144 +24
+ Misses 5578 5567 -11
+ Partials 1330 1326 -4
|
This was referenced Jan 22, 2025
|
For now, this is blocked on at least one dependency being updated. |
|
Merged a PR to avoid breakages in grpc-gcp-go: GoogleCloudPlatform/grpc-gcp-go#91 |
dfawley
approved these changes
Jan 24, 2025
| @@ -293,6 +294,7 @@ func (gsb *Balancer) Close() { | |||
| // State updates from the wrapped balancer can result in invocation of the | |||
| // graceful switch logic. | |||
| type balancerWrapper struct { | |||
| balancer.ClientConn | |||
There was a problem hiding this comment.
If we are embedding now, we can remove the Target implementation.
|
Waiting on release of https://github.com/GoogleCloudPlatform/grpc-gcp-go. |
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #7840, this PR ensures gRPC can add new methods to the ClientConn interface. This change prepares us for passing the metrics recorder to LB policies through the balancer.ClientConn interface instead of the
balancer.BuildOptionsas being done presently. Usingbalancer.BuildOptionsdoesn't allow gRPC to ensure users are propagating the metrics recorder to child LB Policies and can lead to nil pointer dereferences at runtime.RELEASE NOTES:
balancer.ClientConninterface to force implementors to embed a delegate implementation. This helps grpc-go add new methods to the interface without breaking builds for implementors of custom LB Policies.