Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leastrequest: Delegate subchannel creation to pickfirst #7969

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Dec 26, 2024

This PR switches the least request balancer to defer to pick first instead of creating and handling SubConns itself. This is part of Dualstack, and makes this a petiole.

RELEASE NOTES:

  • balancer/leastrequest: Add support for Dualstack.

@arjan-bal arjan-bal added Type: Feature New features or improvements in behavior Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. labels Dec 26, 2024
@arjan-bal arjan-bal added this to the 1.70 Release milestone Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 89.02439% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (f35fb34) to head (dff9584).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
balancer/leastrequest/leastrequest.go 89.02% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7969      +/-   ##
==========================================
- Coverage   82.17%   82.01%   -0.16%     
==========================================
  Files         381      381              
  Lines       38546    38581      +35     
==========================================
- Hits        31676    31644      -32     
- Misses       5560     5612      +52     
- Partials     1310     1325      +15     
Files with missing lines Coverage Δ
balancer/leastrequest/leastrequest.go 88.69% <89.02%> (+1.35%) ⬆️

... and 29 files with indirect coverage changes

@arjan-bal arjan-bal requested a review from dfawley December 26, 2024 04:08
@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc and removed Type: Feature New features or improvements in behavior labels Dec 26, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like some new test cases should be needed, in light of the changes here?

@dfawley dfawley assigned arjan-bal and unassigned dfawley Jan 9, 2025
@arjan-bal arjan-bal force-pushed the least-request-delegate-to-pf branch from 2e60697 to 8135a2a Compare January 13, 2025 09:05
@arjan-bal arjan-bal assigned dfawley and unassigned arjan-bal Jan 13, 2025
@arjan-bal arjan-bal requested a review from dfawley January 13, 2025 09:11
@dfawley dfawley assigned arjan-bal and unassigned dfawley Jan 13, 2025
@arjan-bal arjan-bal merged commit 130c1d7 into grpc:master Jan 15, 2025
14 of 15 checks passed
@arjan-bal arjan-bal deleted the least-request-delegate-to-pf branch January 15, 2025 06:50
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Jan 26, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 13, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 13, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 15, 2025
@arjan-bal arjan-bal modified the milestones: 1.70 Release, 1.71 Release Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants