-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leastrequest: Delegate subchannel creation to pickfirst #7969
leastrequest: Delegate subchannel creation to pickfirst #7969
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7969 +/- ##
==========================================
- Coverage 82.17% 82.01% -0.16%
==========================================
Files 381 381
Lines 38546 38581 +35
==========================================
- Hits 31676 31644 -32
- Misses 5560 5612 +52
- Partials 1310 1325 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like some new test cases should be needed, in light of the changes here?
2e60697
to
8135a2a
Compare
This PR switches the least request balancer to defer to pick first instead of creating and handling SubConns itself. This is part of Dualstack, and makes this a petiole.
RELEASE NOTES: