Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envconfig: enable xDS client fallback by default #7949

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 18, 2024

Interop tests are passing. Setting this to true now will ensure that xDS fallback is ON by default starting v1.70.0.

RELEASE NOTES:

  • xdsclient: fallback to a secondary management server (if specified in the bootstrap configuration) when the primary is down is enabled by default. Can be disabled by setting the environment variable GRPC_EXPERIMENTAL_XDS_FALLBACK to false.

@easwars easwars requested a review from dfawley December 18, 2024 19:42
@easwars easwars added the Type: Feature New features or improvements in behavior label Dec 18, 2024
@easwars easwars added this to the 1.70 Release milestone Dec 18, 2024
@easwars
Copy link
Contributor Author

easwars commented Dec 18, 2024

FYI: @purnesh42H

@dfawley dfawley assigned easwars and unassigned dfawley Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (d0716f9) to head (e8c9f6b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7949      +/-   ##
==========================================
- Coverage   82.14%   82.04%   -0.11%     
==========================================
  Files         379      379              
  Lines       38261    38261              
==========================================
- Hits        31430    31391      -39     
- Misses       5540     5561      +21     
- Partials     1291     1309      +18     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)

... and 20 files with indirect coverage changes

@easwars easwars merged commit f32168c into grpc:master Dec 20, 2024
15 checks passed
@easwars easwars deleted the enable_xds_fallback_by_default branch December 20, 2024 17:51
vinothkumarr227 pushed a commit to vinothkumarr227/grpc-go that referenced this pull request Dec 23, 2024
vinothkumarr227 added a commit to vinothkumarr227/grpc-go that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants